fix: add feature flag retry circuit breaker by marandaneto · Pull Request #247 · PostHog/posthog-dotnet

marandaneto · 2026-06-26T19:39:59Z

💡 Motivation and Context

Stacked on top of #245 to prototype a circuit breaker for /flags retry behavior in a multithreaded/stateless SDK.

The existing retry is bounded per call, but during a broad connectivity issue many concurrent request threads can each sleep and retry independently. This adds a shared circuit breaker so repeated transient /flags transport failures put the SDK into a short cooldown and subsequent calls fail fast instead of all sleeping/retrying.

💚 How did you test it?

dotnet test tests/UnitTests/UnitTests.csproj --filter FullyQualifiedName~HttpClientExtensionsTests
git diff --check

📝 Checklist

I reviewed the submitted code.
I added tests to verify the changes.
I updated the docs if needed.
No breaking change or entry added to the changelog.

If releasing new changes

Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented as a draft stacked PR for review. The circuit opens after consecutive transient /flags failures, fails fast during cooldown, and allows a half-open probe after cooldown. HTTP/API status failures remain non-retryable and do not trip the transient-failure circuit.

github-actions · 2026-06-26T19:41:12Z

posthog-dotnet Compliance Report

Date: 2026-07-02 10:41:55 UTC
Duration: 2313ms

✅ All Tests Passed!

16/16 tests passed

Feature_Flags Tests

✅ 16/16 tests passed

View Details

Test	Status	Duration
Request Payload.Request With Person Properties Device Id	✅	248ms
Request Payload.Flags Request Uses V2 Query Param	✅	123ms
Request Payload.Flags Request Hits Flags Path Not Decide	✅	113ms
Request Payload.Flags Request Omits Authorization Header	✅	109ms
Request Payload.Token In Flags Body Matches Init	✅	110ms
Request Payload.Groups Round Trip	✅	112ms
Request Payload.Groups Default To Empty Object	✅	110ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It	✅	110ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False	✅	109ms
Request Payload.Disable Geoip Omitted Defaults To False	✅	109ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key	✅	109ms
Request Lifecycle.No Flags Request On Init Alone	✅	4ms
Request Lifecycle.No Flags Request On Normal Capture	✅	114ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests	✅	212ms
Request Lifecycle.Mock Response Value Is Returned To Caller	✅	113ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event	✅	211ms

marandaneto · 2026-06-26T19:42:26Z

@haacked wdyt about this circuit break approach? (we can also make the 30s configurable)

greptile-apps · 2026-06-26T20:08:51Z

_{Reviews (1): Last reviewed commit: "fix: add feature flag retry circuit brea..." | Re-trigger Greptile}

haacked · 2026-06-26T20:59:44Z

@marandaneto I meant to submit the review as a comment, not approval! But I trust you to do the right thing. 😄

marandaneto · 2026-06-27T09:19:34Z

@marandaneto I meant to submit the review as a comment, not approval! But I trust you to do the right thing. 😄

thx for the review, yeah it was just a draft with a concept, will check and work on it on monday, then i can port this change across other sdks that have a similar situation

marandaneto · 2026-06-27T09:20:23Z

i re-requested review to remove the approval, but no need to re-review until i address the comments and make it ready for review

…y-circuit-breaker-20260626 # Conflicts: # src/PostHog/Api/PostHogApiClient.cs # src/PostHog/Library/HttpClientExtensions.cs # tests/UnitTests/Library/HttpClientExtensionsTests.cs

greptile-apps · 2026-06-29T11:32:53Z

_{Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile}

marandaneto · 2026-06-30T11:30:19Z

@PostHog/team-client-libraries still pending here

ioannisj

LG, left a couple of comments

…y-circuit-breaker-20260626

haacked

Nice work resolving the earlier feedback! A few more non-blocking suggestions inline.

marandaneto · 2026-07-02T10:45:58Z

will wait for people to upgrade/test/complain (hopefully not) this approach before i add to the sdk test harness/spec/port to other SDKs

marandaneto and others added 7 commits June 25, 2026 08:41

fix: retry feature flag requests on network errors

7240b5e

fix: align flags retry policy with transient errors

6bc124b

fix: make flags retry count configurable

f50c80e

address pr review feedback

e2f7ffa

address pr review feedback

b959699

Merge branch 'main' into pi-flags-network-retry-20260624

2f62269

fix: add feature flag retry circuit breaker

f073e4c

marandaneto requested a review from haacked June 26, 2026 19:42

greptile-apps Bot reviewed Jun 26, 2026

View reviewed changes

Comment thread src/PostHog/Library/HttpClientExtensions.cs

Comment thread src/PostHog/Library/HttpClientExtensions.cs

haacked approved these changes Jun 26, 2026

View reviewed changes

fix: address circuit breaker review feedback

da75990

marandaneto requested a review from haacked June 27, 2026 09:19

fix: honor initial retry delay for flags

346bcd1

Base automatically changed from pi-flags-network-retry-20260624 to main June 29, 2026 08:24

Merge remote-tracking branch 'origin/main' into pi-flags-network-retr…

c2d5e07

…y-circuit-breaker-20260626 # Conflicts: # src/PostHog/Api/PostHogApiClient.cs # src/PostHog/Library/HttpClientExtensions.cs # tests/UnitTests/Library/HttpClientExtensionsTests.cs

marandaneto marked this pull request as ready for review June 29, 2026 11:02

marandaneto requested a review from a team as a code owner June 29, 2026 11:02

marandaneto requested a review from a team June 30, 2026 06:27

ioannisj reviewed Jul 1, 2026

View reviewed changes

Comment thread .changeset/quiet-flags-retry.md Outdated

Comment thread src/PostHog/Library/HttpClientExtensions.cs Outdated

Comment thread src/PostHog/Library/HttpClientExtensions.cs

marandaneto added 2 commits July 1, 2026 12:15

Merge remote-tracking branch 'origin/main' into pi-flags-network-retr…

dc08f71

…y-circuit-breaker-20260626

address pr review feedback

af30ef2

marandaneto requested a review from ioannisj July 1, 2026 10:21

marandaneto requested a review from a team July 1, 2026 10:21

marandaneto added 3 commits July 1, 2026 12:22

restore feature flag retry changeset

0bd20b3

update feature flag circuit breaker changeset

910e425

add aspnet package to changeset

1117640

ioannisj approved these changes Jul 1, 2026

View reviewed changes

haacked reviewed Jul 1, 2026

View reviewed changes

address circuit breaker review feedback

4ad8cc8

marandaneto merged commit 256d2df into main Jul 2, 2026
20 checks passed

marandaneto deleted the pi-flags-network-retry-circuit-breaker-20260626 branch July 2, 2026 10:45

Uh oh!

Conversation

marandaneto commented Jun 26, 2026

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

If releasing new changes

🤖 Agent context

Uh oh!

github-actions Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

posthog-dotnet Compliance Report

✅ All Tests Passed!

Feature_Flags Tests

Uh oh!

marandaneto commented Jun 26, 2026

Uh oh!

greptile-apps Bot commented Jun 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haacked commented Jun 26, 2026

Uh oh!

marandaneto commented Jun 27, 2026

Uh oh!

marandaneto commented Jun 27, 2026

Uh oh!

greptile-apps Bot commented Jun 29, 2026

Uh oh!

marandaneto commented Jun 30, 2026

Uh oh!

ioannisj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haacked left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marandaneto commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 26, 2026 •

edited

Loading